Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft-engine: add the spill-dir config parameter #18690

Merged
merged 6 commits into from
Oct 15, 2024
Merged

raft-engine: add the spill-dir config parameter #18690

merged 6 commits into from
Oct 15, 2024

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Sep 20, 2024 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Release raft-engine.spill-dir configurations for users who wanna uses multi disks for storing raft logs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2024

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2024
@LykxSassinator
Polish annotations.
0d87e25 
Signed-off-by: lucasliang <[email protected]>
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4. labels Sep 20, 2024
@Oreoxmt Oreoxmt requested a review from hfxsd September 20, 2024 07:42
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Sep 20, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 20, 2024
hfxsd
hfxsd reviewed Sep 20, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 20, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@LykxSassinator LykxSassinator mentioned this pull request Sep 20, 2024
Merged
16 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 20, 2024
hfxsd
hfxsd reviewed Sep 20, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
hbisheng
hbisheng reviewed Sep 20, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@LykxSassinator
Address comments.
cb4a81e 
Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2024

@hbisheng: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
@hfxsd hfxsd requested a review from lilin90 September 20, 2024 09:16
@hfxsd hfxsd added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 24, 2024
@lilin90 lilin90 changed the title raft-engine: release spill-dir feature. raft-engine: add the spill-dir config parameter Oct 8, 2024
lilin90
lilin90 reviewed Oct 8, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 08:47:42.518250642 +0000 UTC m=+1210132.258674581: ☑️ agreed by hfxsd.
  • 2024-10-08 10:15:33.643779639 +0000 UTC m=+954689.063992648: ☑️ agreed by lilin90.

@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/retest

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit e6b776a into pingcap:master Oct 15, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18842.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2024
Closed
16 tasks
@hfxsd hfxsd added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Oct 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18843.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 15, 2024
Closed
16 tasks
@hfxsd hfxsd removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 lilin90 approved these changes

@hbisheng hbisheng hbisheng approved these changes

Assignees

@hfxsd hfxsd

Labels
approved contribution This PR is from a community contributor. lgtm needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LykxSassinator @hfxsd @ti-chi-bot @hbisheng @lilin90 @Oreoxmt